Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Format issue on WorkflowEventBinding parameters. Fixes #7042 #7087

Merged
merged 1 commit into from
Oct 28, 2021
Merged

fix: Format issue on WorkflowEventBinding parameters. Fixes #7042 #7087

merged 1 commit into from
Oct 28, 2021

Conversation

jrobertson-insite
Copy link
Contributor

@jrobertson-insite jrobertson-insite commented Oct 27, 2021 •
edited by simster7
Loading

Fixes #7087

@jrobertson-insite jrobertson-insite force-pushed the 7042-format-issue branch 3 times, most recently from 771d198 to 4de8fe8 Compare October 27, 2021 19:13
simster7
simster7 approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @alexec should give the final ok

@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #7087 (398f2dd) into master (64fce4a) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7087      +/-   ##
==========================================
+ Coverage   48.55%   48.61%   +0.05%     
==========================================
  Files         265      265              
  Lines       19329    19329              
==========================================
+ Hits         9386     9397      +11     
+ Misses       8892     8879      -13     
- Partials     1051     1053       +2
Impacted Files Coverage Δ
pkg/apis/workflow/v1alpha1/item.go 77.35% <100.00%> (ø)
cmd/argoexec/commands/emissary.go 51.79% <0.00%> (+1.43%) ⬆️
server/workflow/workflow_server.go 46.80% <0.00%> (+2.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64fce4a...398f2dd. Read the comment docs.

@alexec alexec marked this pull request as ready for review October 28, 2021 16:31
@alexec alexec merged commit c5de76b into argoproj:master Oct 28, 2021
@alexec
Copy link
Contributor

alexec commented Oct 28, 2021

Merging...

@alexec alexec mentioned this pull request Nov 5, 2021
Closed
25 tasks
@sarabala1979 sarabala1979 mentioned this pull request Dec 15, 2021
Closed
73 tasks
sarabala1979 pushed a commit that referenced this pull request Dec 15, 2021
@jrobertson-insite @sarabala1979
fix: Format issue on WorkflowEventBinding parameters. Fixes #7042 (#7087
9261080 
)

Signed-off-by: Jonathan Robertson <[email protected]>
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simster7 simster7 simster7 approved these changes

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrobertson-insite @alexec @simster7