Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add user's email in the server gatekeeper logs #7062

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

julienduchesne
Copy link
Contributor

@julienduchesne julienduchesne commented Oct 26, 2021

The claim subject is sometimes a number which is not very descriptive
This adds the email (if it is set) as a log field

The claim subject is sometimes a number which is not very description
This adds the email (if it is set) as a log field

Signed-off-by: Julien Duchesne <[email protected]>
@julienduchesne julienduchesne changed the title Add user's email in the server gatekeeper logs feat: Add user's email in the server gatekeeper logs Oct 26, 2021
@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #7062 (60ba0c3) into master (18c953d) will increase coverage by 0.00%.
The diff coverage is 77.77%.

❗ Current head 60ba0c3 differs from pull request most recent head e6d6aa6. Consider uploading reports for the commit e6d6aa6 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7062   +/-   ##
=======================================
  Coverage   48.54%   48.55%           
=======================================
  Files         265      265           
  Lines       19307    19314    +7     
=======================================
+ Hits         9373     9378    +5     
  Misses       8880     8880           
- Partials     1054     1056    +2     
Impacted Files Coverage Δ
server/auth/gatekeeper.go 50.00% <77.77%> (+0.95%) ⬆️
cmd/argoexec/commands/emissary.go 50.35% <0.00%> (-1.44%) ⬇️
workflow/metrics/server.go 19.29% <0.00%> (+3.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18c953d...e6d6aa6. Read the comment docs.

@alexec alexec merged commit 60f2ae9 into argoproj:master Oct 26, 2021
@alexec
Copy link
Contributor

alexec commented Oct 26, 2021

LGTM

@sarabala1979 sarabala1979 mentioned this pull request Oct 26, 2021
25 tasks
@sarabala1979 sarabala1979 mentioned this pull request Nov 4, 2021
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants