fix: Restore default pod name version to v1 #6998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: J.P. Zivalich <[email protected]>
Signed-off-by: J.P. Zivalich <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #6998 +/- ##
==========================================
- Coverage 48.52% 48.45% -0.07%
==========================================
Files 265 265
Lines 19272 19273 +1
==========================================
- Hits 9352 9339 -13
- Misses 8867 8885 +18
+ Partials 1053 1049 -4
Continue to review full report at Codecov.
|
sarabala1979
approved these changes
Oct 21, 2021
sarabala1979
pushed a commit
that referenced
this pull request
Oct 21, 2021
* fix: Restore default pod name version to v1 Signed-off-by: J.P. Zivalich <[email protected]> * Update ui test Signed-off-by: J.P. Zivalich <[email protected]>
kriti-sc
pushed a commit
to kriti-sc/argo-workflows
that referenced
this pull request
Oct 24, 2021
* fix: Restore default pod name version to v1 Signed-off-by: J.P. Zivalich <[email protected]> * Update ui test Signed-off-by: J.P. Zivalich <[email protected]> Signed-off-by: kriti-sc <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: J.P. Zivalich [email protected]
This PR:
Given some of the edge case issues (#6989, #6947) with the default v2 pod names, switch the default back to v1