feat(server): Sync dispatch of webhook events by default. Fixes #6981 and #6732 #6995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roj#6981 and argoproj#6732 Signed-off-by: Alex Collins <[email protected]>
…proj#6981 and argoproj#6732 Signed-off-by: Alex Collins <[email protected]>
…proj#6981 and argoproj#6732 Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
whynowy
reviewed
Oct 21, 2021
| } | ||
| } | ||
| if len(errs) > 0 { |
There was a problem hiding this comment.
How is #6732 addressed? Returning an error?
There was a problem hiding this comment.
No. Duplicates are now ignored.
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #6995 +/- ##
==========================================
+ Coverage 48.49% 48.55% +0.05%
==========================================
Files 265 265
Lines 19281 19294 +13
==========================================
+ Hits 9351 9368 +17
+ Misses 8881 8872 -9
- Partials 1049 1054 +5
Continue to review full report at Codecov.
|
Signed-off-by: Alex Collins <[email protected]>
kriti-sc
pushed a commit
to kriti-sc/argo-workflows
that referenced
this pull request
Oct 24, 2021
…roj#6981 and argoproj#6732 (argoproj#6995) Signed-off-by: Alex Collins <[email protected]> Signed-off-by: kriti-sc <[email protected]>
alexec
added a commit
that referenced
this pull request
Oct 24, 2021
…and #6732 (#6995) Signed-off-by: Alex Collins <[email protected]>
Closed
|
When will this be pulled into a release? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6981
Fixes #6732
Signed-off-by: Alex Collins [email protected]