Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Parameter with Value and Default #6887

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

sarabala1979
Copy link
Member

@sarabala1979 sarabala1979 commented Oct 7, 2021

Signed-off-by: Saravanan Balasubramanian [email protected]
closes #6880

Tips:

  • Maybe add you organization to USERS.md.
  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
  • Sign-off your commits to pass the DCO check: git commit --signoff.
  • Run make pre-commit -B to fix codegen or lint problems.
  • Say how how you tested your changes. If you changed the UI, attach screenshots.
  • If changes were requested, and you've made them, then dismis the review to get it looked at again.
  • You can ask for help!

Signed-off-by: Saravanan Balasubramanian <[email protected]>
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #6887 (0337c61) into master (53057a1) will decrease coverage by 0.20%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6887      +/-   ##
==========================================
- Coverage   48.70%   48.49%   -0.21%     
==========================================
  Files         265      265              
  Lines       19161    19258      +97     
==========================================
+ Hits         9332     9340       +8     
- Misses       8784     8865      +81     
- Partials     1045     1053       +8     
Impacted Files Coverage Δ
workflow/common/util.go 14.59% <0.00%> (ø)
persist/sqldb/archived_workflow_labels.go 44.82% <0.00%> (-33.97%) ⬇️
server/workflowarchive/archived_workflow_server.go 59.43% <0.00%> (-2.30%) ⬇️
cmd/argo/commands/get.go 58.89% <0.00%> (-1.46%) ⬇️
cmd/argoexec/commands/emissary.go 50.35% <0.00%> (-1.44%) ⬇️
persist/sqldb/migrate.go 0.00% <0.00%> (ø)
pkg/apiclient/http1-client.go 0.00% <0.00%> (ø)
persist/sqldb/workflow_archive.go 0.00% <0.00%> (ø)
pkg/apiclient/argo-kube-client.go 0.00% <0.00%> (ø)
pkg/apiclient/argo-server-client.go 0.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53057a1...0337c61. Read the comment docs.

@alexec
Copy link
Contributor

alexec commented Oct 7, 2021

test would be nice

@apiwoni
Copy link

apiwoni commented Oct 7, 2021

@sarabala1979 #6887 Does this fix does resolve all issues 1, 2, 3 and 4 in #6880?

This was referenced Oct 15, 2021
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this pull request Oct 24, 2021
Signed-off-by: Saravanan Balasubramanian <[email protected]>
Signed-off-by: kriti-sc <[email protected]>
@alexec alexec mentioned this pull request Nov 5, 2021
25 tasks
alexec pushed a commit that referenced this pull request Nov 17, 2021
Signed-off-by: Saravanan Balasubramanian <[email protected]>
@sarabala1979 sarabala1979 mentioned this pull request Dec 15, 2021
73 tasks
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

templateDefaults has inconsistent behavior and does not allow command line parameter overwrite
3 participants