Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade sprig to v3.2.2 #6876

Merged
merged 2 commits into from
Oct 6, 2021
Merged

fix: upgrade sprig to v3.2.2 #6876

merged 2 commits into from
Oct 6, 2021

Conversation

wanghong230
Copy link
Member

fix #6863

Signed-off-by: Hong Wang [email protected]

Tips:

  • Maybe add you organization to USERS.md.
  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
  • Sign-off your commits to pass the DCO check: git commit --signoff.
  • Run make pre-commit -B to fix codegen or lint problems.
  • Say how how you tested your changes. If you changed the UI, attach screenshots.
  • If changes were requested, and you've made them, then dismis the review to get it looked at again.
  • You can ask for help!

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Any idea whether this will solve the workflow.name problem mentioned in the issue?

@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #6876 (f94c45d) into master (53057a1) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head f94c45d differs from pull request most recent head bb8047a. Consider uploading reports for the commit bb8047a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6876      +/-   ##
==========================================
- Coverage   48.70%   48.64%   -0.07%     
==========================================
  Files         265      265              
  Lines       19161    19161              
==========================================
- Hits         9332     9320      -12     
- Misses       8784     8792       +8     
- Partials     1045     1049       +4     
Impacted Files Coverage Δ
cmd/argo/commands/get.go 58.30% <0.00%> (-2.05%) ⬇️
cmd/argoexec/commands/emissary.go 50.35% <0.00%> (-1.44%) ⬇️
workflow/controller/operator.go 70.97% <0.00%> (-0.24%) ⬇️
workflow/metrics/server.go 19.29% <0.00%> (+3.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53057a1...bb8047a. Read the comment docs.

@alexec alexec enabled auto-merge (squash) October 6, 2021 17:11
@alexec alexec merged commit c962bb1 into argoproj:master Oct 6, 2021
@wanghong230
Copy link
Member Author

lgtm. Any idea whether this will solve the workflow.name problem mentioned in the issue?

No, it won't. I am following up on that.

This was referenced Oct 15, 2021
sarabala1979 pushed a commit that referenced this pull request Oct 19, 2021
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this pull request Oct 24, 2021
Signed-off-by: Hong Wang <[email protected]>
Signed-off-by: kriti-sc <[email protected]>
@alexec alexec mentioned this pull request Nov 5, 2021
25 tasks
@sarabala1979 sarabala1979 mentioned this pull request Dec 15, 2021
73 tasks
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sprig truncate doesn't work with workflow.name. Negative truncate doesn't work at all.
3 participants