Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add HTTP genre and sort #6798

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Conversation

rwong2888
Copy link
Contributor

Fix #6794

@alexec alexec changed the title add HTTP genre and sort fix: add HTTP genre and sort Sep 23, 2021
@alexec
Copy link
Contributor

alexec commented Sep 23, 2021

Thank you. Were you able to test this? If so, could you share a screenshot?

@rwong2888
Copy link
Contributor Author

@alexec I'll set up locally and test when I get a chance.
https://argoproj.github.io/argo-workflows/running-locally/

@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #6798 (5ee6ff4) into master (44fd714) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6798      +/-   ##
==========================================
+ Coverage   48.74%   48.78%   +0.03%     
==========================================
  Files         265      265              
  Lines       19109    19116       +7     
==========================================
+ Hits         9314     9325      +11     
+ Misses       8746     8744       -2     
+ Partials     1049     1047       -2     
Impacted Files Coverage Δ
workflow/controller/operator.go 71.21% <0.00%> (ø)
pkg/apis/workflow/v1alpha1/workflow_types.go 50.33% <0.00%> (ø)
workflow/controller/workflowpod.go 74.41% <0.00%> (+0.23%) ⬆️
cmd/argo/commands/get.go 58.89% <0.00%> (+0.58%) ⬆️
cmd/argoexec/commands/emissary.go 51.79% <0.00%> (+1.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44fd714...5ee6ff4. Read the comment docs.

@sarabala1979
Copy link
Member

@rwong2888 Can you fix the DCO and semantics?

@rwong2888
Copy link
Contributor Author

Not following. Can you elaborate @sarabala1979 ?

@sarabala1979
Copy link
Member

@rwong2888 Can you sign in DCO?

@alexec
Copy link
Contributor

alexec commented Sep 28, 2021

Hi, you have two failing checks:

image

Click on "Details" to fine out how to fix them. Should only take 5m.

Copy link
Member

@whynowy whynowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DCO please.

Signed-off-by: rwong2888 <[email protected]>
@rwong2888
Copy link
Contributor Author

Thank you. Am new to this. Added DCO @sarabala1979 , @alexec , @whynowy

I think @alexec fixed the semantics with the title change to fix:

@alexec
Copy link
Contributor

alexec commented Sep 29, 2021

Semantic Pull Request — PR has only one non-merge commit and it's not semantic; add another commit before squashing

@alexec alexec merged commit 4f4157b into argoproj:master Sep 29, 2021
@rwong2888
Copy link
Contributor Author

A little after the fact and it took me a while to set up, but here is a screenshot @alexec !

image

kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this pull request Oct 24, 2021
Signed-off-by: rwong2888 <[email protected]>
Signed-off-by: kriti-sc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Steps after httpTemplate are not visible
4 participants