Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): report phase button alignment. Fixes #4974 #6707

Conversation

tczhao
Copy link
Member

@tczhao tczhao commented Sep 12, 2021

fixes #4974

from:
image

to:
image

Tips:

  • Maybe add you organization to USERS.md.
  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
  • Sign-off your commits to pass the DCO check: git commit --signoff.
  • Run make pre-commit -B to fix codegen or lint problems.
  • Say how how you tested your changes. If you changed the UI, attach screenshots.
  • If changes were requested, and you've made them, then dismis the review to get it looked at again.
  • You can ask for help!

@codecov
Copy link

codecov bot commented Sep 12, 2021

Codecov Report

Merging #6707 (3aa708a) into master (fd53500) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6707   +/-   ##
=======================================
  Coverage   48.61%   48.61%           
=======================================
  Files         263      263           
  Lines       19018    19018           
=======================================
  Hits         9245     9245           
- Misses       8736     8737    +1     
+ Partials     1037     1036    -1     
Impacted Files Coverage Δ
workflow/controller/operator.go 71.04% <0.00%> (-0.10%) ⬇️
cmd/argoexec/commands/emissary.go 51.79% <0.00%> (+1.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd53500...3aa708a. Read the comment docs.

@sarabala1979 sarabala1979 merged commit 1e31eb8 into argoproj:master Sep 12, 2021
@sarabala1979 sarabala1979 mentioned this pull request Sep 13, 2021
13 tasks
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this pull request Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkboxes should have labels text adjacent to buttons
2 participants