Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix kill sidecar timeout issue. Fixes ##6693 #6700

Merged
merged 1 commit into from
Sep 13, 2021
Merged

fix: Fix kill sidecar timeout issue. Fixes ##6693 #6700

merged 1 commit into from
Sep 13, 2021

Conversation

henrywangx
Copy link
Contributor

@henrywangx henrywangx commented Sep 10, 2021 •
edited by alexec
Loading

Fixes ##6693

@henrywangx henrywangx mentioned this pull request Sep 10, 2021
Closed
@alexec alexec changed the title #6693 fix kill sidecar timeout issue fix: Fix kill sidecar timeout issue. Fixes ##6693 Sep 10, 2021
@alexec
Copy link
Contributor

alexec commented Sep 10, 2021

Please can you sign-off your commits to pass the DCO check?

alexec
alexec approved these changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you sign-off your commits to pass the DCO check?

@alexec alexec enabled auto-merge (squash) September 10, 2021 15:27
@codecov
Copy link

codecov bot commented Sep 10, 2021 •
edited
Loading

Codecov Report

Merging #6700 (0e45183) into master (4b5d7ec) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6700      +/-   ##
==========================================
+ Coverage   48.57%   48.58%   +0.01%     
==========================================
  Files         263      263              
  Lines       19018    19034      +16     
==========================================
+ Hits         9238     9248      +10     
- Misses       8746     8749       +3     
- Partials     1034     1037       +3
Impacted Files Coverage Δ
workflow/executor/k8sapi/client.go 0.00% <0.00%> (ø)
workflow/metrics/server.go 15.78% <0.00%> (-3.51%) ⬇️
pkg/apiclient/apiclient.go 5.55% <0.00%> (-2.14%) ⬇️
cmd/argo/commands/get.go 59.18% <0.00%> (-0.59%) ⬇️
cmd/argo/commands/watch.go 0.00% <0.00%> (ø)
cmd/argo/commands/client/conn.go 15.09% <0.00%> (ø)
cmd/argo/commands/cron/create.go 0.00% <0.00%> (ø)
persist/sqldb/workflow_archive.go 0.00% <0.00%> (ø)
cmd/argo/commands/clustertemplate/create.go 13.72% <0.00%> (ø)
cmd/argo/commands/clustertemplate/delete.go 0.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b5d7ec...0e45183. Read the comment docs.

@sarabala1979
Copy link
Member

@henrywangx Please can you sign-off your commits to pass the DCO check?

auto-merge was automatically disabled September 13, 2021 08:11

Head branch was pushed to by a user without write access

@henrywangx
Copy link
Contributor Author

@henrywangx Please can you sign-off your commits to pass the DCO check?

@sarabala1979 done. Meanwhile I'm wondering how we cherry pick this fix into other releases after merged(sorry, I'm new to open source contribution).

@alexec alexec enabled auto-merge (squash) September 13, 2021 14:48
@alexec alexec merged commit 0b3f62c into argoproj:master Sep 13, 2021
@sarabala1979 sarabala1979 mentioned this pull request Sep 13, 2021
Closed
13 tasks
@alexec alexec linked an issue Sep 21, 2021 that may be closed by this pull request
set stdout=true when kill sidecars #6693
Closed
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this pull request Oct 24, 2021
@henrywangx @kriti-sc
fix: kill sidecar timeout issue (argoproj#6700)
2d20b9a 
Signed-off-by: xiong wang <[email protected]>

Co-authored-by: xiong wang <[email protected]>
Signed-off-by: kriti-sc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

set stdout=true when kill sidecars
3 participants
@henrywangx @alexec @sarabala1979