Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenID Connect auth support #663

Merged
merged 2 commits into from
Jan 8, 2018
Merged

Conversation

mthx
Copy link
Contributor

@mthx mthx commented Jan 8, 2018

Add OpenID Connect authentication support by loading the relevant auth plugin wherever the gce one is loaded.

My organisation runs Kubernetes with Keycloak as an OpenID Connect Identity Provider. There are a variety of other common options supported by this plugin - see https://kubernetes.io/docs/admin/authentication/#option-1---oidc-authenticator.

I've now successfully installed argo and run a hello-world workflow on such a cluster. Previously the install failed as it wasn't possible to authenticate.

I haven't looked into how auth works for argoexec / workflow-controller, so I've just followed the gce pattern there.

Add the oidc plugin wherever gcp is added.
@jessesuen jessesuen self-requested a review January 8, 2018 22:04
@jessesuen
Copy link
Member

I think dep ensure may be needed to regenerate the Gopkg.lock file after adding the import, but I don't see any changes to Gopkg.lock as part of the commit. Can you run dep ensure with new import and update the PR?

@mthx
Copy link
Contributor Author

mthx commented Jan 8, 2018

Thanks - I've pushed the updated lock file.

@jessesuen jessesuen merged commit 3cca098 into argoproj:master Jan 8, 2018
icecoffee531 pushed a commit to icecoffee531/argo-workflows that referenced this pull request Jan 5, 2022
…loses argoproj#663. (argoproj#664)

* feat: add affinity, tolerations in template and clusterIP in service

* correct order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants