Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed typo in clusterrole #6626

Merged
merged 1 commit into from
Aug 31, 2021
Merged

fix: Fixed typo in clusterrole #6626

merged 1 commit into from
Aug 31, 2021

Conversation

sarabala1979
Copy link
Member

Signed-off-by: Saravanan Balasubramanian [email protected]

Tips:

  • Maybe add you organization to USERS.md.
  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
  • Sign-off your commits to pass the DCO check: git commit --signoff.
  • Run make pre-commit -B to fix codegen or lint problems.
  • Say how how you tested your changes. If you changed the UI, attach screenshots.
  • If changes were requested, and you've made them, then dismis the review to get it looked at again.
  • You can ask for help!

@sarabala1979
fix: Fixed typo in clusterrole
4f6db2c 
Signed-off-by: Saravanan Balasubramanian <[email protected]>
@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #6626 (0979fdc) into master (51307e1) will not change coverage.
The diff coverage is n/a.

❗ Current head 0979fdc differs from pull request most recent head 4f6db2c. Consider uploading reports for the commit 4f6db2c to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6626   +/-   ##
=======================================
  Coverage   48.59%   48.59%           
=======================================
  Files         261      261           
  Lines       18978    18978           
=======================================
  Hits         9222     9222           
- Misses       8728     8729    +1     
+ Partials     1028     1027    -1
Impacted Files Coverage Δ
workflow/metrics/server.go 15.78% <0.00%> (-3.51%) ⬇️
cmd/argoexec/commands/emissary.go 51.79% <0.00%> (+1.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51307e1...4f6db2c. Read the comment docs.

@sarabala1979 sarabala1979 enabled auto-merge (squash) August 31, 2021 06:22
terrytangyuan
terrytangyuan approved these changes Aug 31, 2021
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sarabala1979 sarabala1979 merged commit d8b90f2 into argoproj:master Aug 31, 2021
@sarabala1979 sarabala1979 mentioned this pull request Sep 2, 2021
Closed
61 tasks
@sarabala1979 sarabala1979 mentioned this pull request Sep 9, 2021
Closed
68 tasks
JPZ13 pushed a commit to JPZ13/argo-workflows that referenced this pull request Sep 26, 2021
@alexec @JPZ13
feat: Multi-cloud/cluster/namespace workflows. Fixes argoproj#6089, a…
0c78f19 
…rgoproj#3523, argoproj#2063

Signed-off-by: Alex Collins <[email protected]>

mre

Signed-off-by: Alex Collins <[email protected]>

bits

Signed-off-by: Alex Collins <[email protected]>

fix(executor): Disambiguate PNS executor initialization log (argoproj#6582)

Signed-off-by: Yuan Tang <[email protected]>

ci: Disable builds on forks (argoproj#6589)

Signed-off-by: Yuan Tang <[email protected]>

fix!: Enable authentication by default on Argo Server `/metrics` endpoint. Fixes argoproj#6592 (argoproj#6595)

Signed-off-by: Alex Collins <[email protected]>

ok

Signed-off-by: Alex Collins <[email protected]>

ok

Signed-off-by: Alex Collins <[email protected]>

ok

Signed-off-by: Alex Collins <[email protected]>

chore: Upgrade cobra to v1.2.1  (argoproj#6597)

Signed-off-by: Alex Collins <[email protected]>

ok

Signed-off-by: Alex Collins <[email protected]>

ok

Signed-off-by: Alex Collins <[email protected]>

docs: Document auth rate limiting. Fixes argoproj#5217

docs: Document IP address logging. Fixes argoproj#5216

fix: Fix `gosec` warnings, disable pprof by default. Fixes argoproj#6594 (argoproj#6596)

Signed-off-by: Alex Collins <[email protected]>

ok

Signed-off-by: Alex Collins <[email protected]>

fix tests

Signed-off-by: Alex Collins <[email protected]>

fix/skip tests

Signed-off-by: Alex Collins <[email protected]>

ok

Signed-off-by: Alex Collins <[email protected]>

ok

Signed-off-by: Alex Collins <[email protected]>

o

Signed-off-by: Alex Collins <[email protected]>

ok

Signed-off-by: Alex Collins <[email protected]>

ok

Signed-off-by: Alex Collins <[email protected]>

docs: Fix template-defaults duplicated in docs and add missing whitespace in h1 (argoproj#6601)

Signed-off-by: Michael Pöllath <[email protected]>

docs: fix continue on failure dag example (argoproj#6609)

Signed-off-by: Siebren Zwerver <[email protected]>

fix: manifests/quick-start/sso for running locally PROFILE=sso (argoproj#6503)

Signed-off-by: Tetsuya Shiota <[email protected]>

chore: Run `make codegen`

Signed-off-by: Alex Collins <[email protected]>

build: disable UI by default for `make start`

docs: Document argoproj#6297 breaking change (argoproj#6616)

docs: Remove sym-links from docs (argoproj#6617)

Signed-off-by: Alex Collins <[email protected]>

upgrade to v0.0.9

Signed-off-by: Alex Collins <[email protected]>

fix test

Signed-off-by: Alex Collins <[email protected]>

fix tests

Signed-off-by: Alex Collins <[email protected]>

add missing label selector

Signed-off-by: Alex Collins <[email protected]>

add transport wrappers

Signed-off-by: Alex Collins <[email protected]>

fix clean-up keys

Signed-off-by: Alex Collins <[email protected]>

ok

Signed-off-by: Alex Collins <[email protected]>

ok

Signed-off-by: Alex Collins <[email protected]>

fix: quay.io stuffs

Signed-off-by: Alex Collins <[email protected]>

fix: support in-cluster correctly

Signed-off-by: Alex Collins <[email protected]>

ok

Signed-off-by: Alex Collins <[email protected]>

fix(controller): Initialize throttler during starting workflow-controller. Fixes: argoproj#6599 (argoproj#6608)

Signed-off-by: smile-luobin <[email protected]>

 docs: Add slack exit handler example. Resolves argoproj#4152  (argoproj#6612)

Signed-off-by: J.P. Zivalich <[email protected]>

fix: Argo Workflow specs link to not go to raw content (argoproj#6624)

Signed-off-by: Andrey Melnikov <[email protected]>

ci: Build Docker manifest with complete dep list (argoproj#6621)

Signed-off-by: Curtis Vogt <[email protected]>

fix: Upgrade Dataflow to v0.0.96 (argoproj#6622)

Signed-off-by: Alex Collins <[email protected]>

ok

Signed-off-by: Alex Collins <[email protected]>

docs: Fix incorrect link to examples (argoproj#6630)

Signed-off-by: Yuan Tang <[email protected]>

fix: Fixed typo in clusterrole (argoproj#6626)

Signed-off-by: Saravanan Balasubramanian <[email protected]>

build: Fix repository prefix (argoproj#6636)

Signed-off-by: Alex Collins <[email protected]>

feat: Upgrade dataflow to v0.0.98 (argoproj#6637)

Signed-off-by: Alex Collins <[email protected]>

docs: correct https://bit.ly/book-30m-with-argo-team URL

feat(controller): Add a shared index informer for ConfigMaps (argoproj#6644)

Signed-off-by: Yuan Tang <[email protected]>

Fix duplicated import

Signed-off-by: J.P. Zivalich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

@terrytangyuan terrytangyuan terrytangyuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sarabala1979 @alexec @terrytangyuan