Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Docker manifest only when all dependencies are ready #6621

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Build Docker manifest only when all dependencies are ready #6621

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 2 additions & 45 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,55 +190,11 @@ jobs:
docker push quay.io/$image_name
done

push-linux-amd64-images:
name: Push manifest with linux/amd64
if: github.repository == 'argoproj/argo-workflows'
runs-on: ubuntu-20.04
needs: [ build-linux-amd64 ]
steps:
- uses: actions/checkout@v2
- name: Docker Login
uses: Azure/docker-login@v1
with:
username: ${{ secrets.DOCKERIO_USERNAME }}
password: ${{ secrets.DOCKERIO_PASSWORD }}

- name: Login to Quay
uses: Azure/docker-login@v1
with:
login-server: quay.io
username: ${{ secrets.QUAYIO_USERNAME }}
password: ${{ secrets.QUAYIO_PASSWORD }}

- name: Push Multiarch Image
env:
DOCKERIO_ORG: ${{ secrets.DOCKERIO_ORG }}
run: |
echo $(jq -c '. + { "experimental": "enabled" }' ${DOCKER_CONFIG}/config.json) > ${DOCKER_CONFIG}/config.json

docker_org=$DOCKERIO_ORG

tag=$(basename $GITHUB_REF)
if [ $tag = "master" ]; then
tag="latest"
fi

targets="workflow-controller argoexec argocli"
for target in $targets; do
image_name="${docker_org}/${target}:${tag}"

docker manifest create $image_name ${image_name}-linux-amd64
docker manifest create quay.io/$image_name quay.io/${image_name}-linux-amd64

docker manifest push $image_name
docker manifest push quay.io/$image_name
done

push-images:
name: Push manifest with all images
if: github.repository == 'argoproj/argo-workflows'
runs-on: ubuntu-20.04
needs: [ build-linux-arm64, build-windows, push-linux-amd64-images ]
needs: [ build-linux-amd64, build-linux-arm64, build-windows ]
steps:
- uses: actions/checkout@v2
- name: Docker Login
Expand Down Expand Up @@ -282,6 +238,7 @@ jobs:
docker manifest push $image_name
docker manifest push quay.io/$image_name
done

test-images-linux-amd64:
name: Try pulling linux/amd64
if: github.repository == 'argoproj/argo-workflows'
Expand Down