fix(executor): Fix kubectl permission error
#6091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Collins <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #6091 +/- ##
==========================================
- Coverage 47.76% 47.75% -0.01%
==========================================
Files 249 249
Lines 15737 15739 +2
==========================================
Hits 7516 7516
- Misses 7282 7283 +1
- Partials 939 940 +1
Continue to review full report at Codecov.
|
Signed-off-by: Alex Collins <[email protected]>
alexec
commented
Jun 5, 2021
| exErr := err.(*exec.ExitError) | ||
| errMsg := strings.TrimSpace(string(exErr.Stderr)) | ||
| return "", "", "", errors.New(errors.CodeBadRequest, errMsg) | ||
| if exErr, ok := err.(*exec.ExitError); ok { |
|
This PR fixes master build. |
alexec
changed the title
kubectl error
alexec
changed the title
kubectl error kubectl permission error
sarabala1979
approved these changes
Jun 7, 2021
alexec
changed the title
kubectl permission error kubectl permission error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Collins [email protected]