Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix make codegen #6090

Merged
merged 5 commits into from
Jun 7, 2021
Merged

build: Fix make codegen #6090

merged 5 commits into from
Jun 7, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jun 5, 2021

Signed-off-by: Alex Collins [email protected]

Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
@alexec alexec changed the title ci: Fix make manifests build: Fix make codegen Jun 5, 2021
@codecov
Copy link

codecov bot commented Jun 5, 2021

Codecov Report

Merging #6090 (623c66d) into master (245764e) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 623c66d differs from pull request most recent head 72be238. Consider uploading reports for the commit 72be238 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6090      +/-   ##
==========================================
- Coverage   47.77%   47.75%   -0.03%     
==========================================
  Files         249      249              
  Lines       15739    15739              
==========================================
- Hits         7520     7516       -4     
- Misses       7279     7283       +4     
  Partials      940      940              
Impacted Files Coverage Δ
cmd/argoexec/commands/emissary.go 48.43% <0.00%> (-1.57%) ⬇️
cmd/argo/commands/get.go 57.09% <0.00%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 245764e...72be238. Read the comment docs.

@alexec
Copy link
Contributor Author

alexec commented Jun 5, 2021

eh?

Failed Error (exit code 1): interface conversion: error is *exec.Error, not *exec.ExitError

@alexec alexec marked this pull request as ready for review June 6, 2021 17:50
@alexec alexec enabled auto-merge (squash) June 6, 2021 17:50
@alexec alexec added this to the v3.2 milestone Jun 6, 2021
@alexec alexec merged commit c183058 into argoproj:master Jun 7, 2021
@alexec alexec deleted the manifests branch June 7, 2021 19:31
alexec added a commit that referenced this pull request Jun 8, 2021
Signed-off-by: Alex Collins <[email protected]>
@alexec alexec mentioned this pull request Jun 10, 2021
20 tasks
@sarabala1979 sarabala1979 mentioned this pull request Jun 10, 2021
88 tasks
@alexec alexec mentioned this pull request Jun 21, 2021
16 tasks
@@ -9,4 +9,4 @@ roleRef:
subjects:
- kind: ServiceAccount
name: argo
namespace: default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alexec!
Modifying this line break compatibility with dynamic change namespace insert by me here #5907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants