Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Add text filter to logs. Fixes #6059 #6061

Merged
merged 6 commits into from
Jun 2, 2021
Merged

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jun 2, 2021

Signed-off-by: Alex Collins [email protected]
Fixes #6059

  1. Filters log lines based on grep.
  2. Highlight the grepped terms in the line.

Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
@alexec alexec changed the title feat(ui): Add text filter to logs feat(ui): Add text filter to logs. Fixes #6059 Jun 2, 2021
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #6061 (1eea088) into master (f1fcb43) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

❗ Current head 1eea088 differs from pull request most recent head e6eef28. Consider uploading reports for the commit e6eef28 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6061      +/-   ##
==========================================
- Coverage   47.52%   47.47%   -0.06%     
==========================================
  Files         248      248              
  Lines       15721    15724       +3     
==========================================
- Hits         7472     7465       -7     
- Misses       7312     7322      +10     
  Partials      937      937              
Impacted Files Coverage Δ
cmd/argo/commands/logs.go 0.00% <0.00%> (ø)
cmd/argo/commands/submit.go 0.00% <0.00%> (ø)
workflow/metrics/server.go 12.50% <0.00%> (-4.17%) ⬇️
workflow/controller/operator.go 70.69% <0.00%> (-0.28%) ⬇️
cmd/argo/commands/get.go 57.09% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1fcb43...e6eef28. Read the comment docs.

@alexec alexec marked this pull request as ready for review June 2, 2021 17:03
@alexec alexec requested a review from jessesuen as a code owner June 2, 2021 17:03
Copy link
Member

@sarabala1979 sarabala1979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Alex Collins <[email protected]>
@alexec alexec added this to the v3.1 milestone Jun 2, 2021
@alexec alexec merged commit 1f3493a into argoproj:master Jun 2, 2021
@alexec alexec deleted the filter branch June 2, 2021 17:35
@sarabala1979 sarabala1979 mentioned this pull request Jun 10, 2021
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Make logs searchable
3 participants