Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): Add per-namespace parallelism limits. Closes #6037 #6039

Merged
merged 6 commits into from
May 27, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented May 27, 2021

Signed-off-by: Alex Collins [email protected]

@alexec alexec linked an issue May 27, 2021 that may be closed by this pull request
Signed-off-by: Alex Collins <[email protected]>
@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #6039 (ac43855) into master (73539fa) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6039      +/-   ##
==========================================
+ Coverage   47.39%   47.51%   +0.12%     
==========================================
  Files         247      248       +1     
  Lines       15693    15722      +29     
==========================================
+ Hits         7438     7471      +33     
+ Misses       7320     7316       -4     
  Partials      935      935              
Impacted Files Coverage Δ
config/config.go 73.91% <ø> (ø)
workflow/controller/controller.go 20.65% <100.00%> (+0.82%) ⬆️
workflow/controller/operator.go 70.66% <100.00%> (ø)
workflow/sync/chain_throttler.go 100.00% <100.00%> (ø)
workflow/sync/throttler.go 95.94% <100.00%> (+1.30%) ⬆️
cmd/argo/commands/get.go 57.74% <0.00%> (+0.64%) ⬆️
cmd/argoexec/commands/emissary.go 50.00% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73539fa...ac43855. Read the comment docs.

Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
@alexec alexec marked this pull request as ready for review May 27, 2021 22:03
@alexec alexec merged commit e262b3a into argoproj:master May 27, 2021
@alexec alexec deleted the nsp branch May 27, 2021 23:07
@alexec alexec added this to the v3.1 milestone May 27, 2021
@sarabala1979 sarabala1979 mentioned this pull request Jun 10, 2021
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

better multi-tenancy: limit workflows running on a per-namespace basis
2 participants