fix(controller): Fix active pods count in node pending status with pod deleted. #5836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saravanan Balasubramanian <[email protected]>
Signed-off-by: Saravanan Balasubramanian <[email protected]>
Signed-off-by: Saravanan Balasubramanian <[email protected]>
Signed-off-by: Saravanan Balasubramanian <[email protected]>
Signed-off-by: Saravanan Balasubramanian <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #5836 +/- ##
==========================================
+ Coverage 47.20% 47.36% +0.16%
==========================================
Files 246 247 +1
Lines 15520 15595 +75
==========================================
+ Hits 7326 7387 +61
Misses 7280 7280
- Partials 914 928 +14
Continue to review full report at Codecov.
|
Signed-off-by: Saravanan Balasubramanian <[email protected]>
Signed-off-by: Saravanan Balasubramanian <[email protected]>
alexec
requested changes
May 10, 2021
go.mod
Outdated
| @@ -24,6 +24,7 @@ require ( | |||
| github.com/evanphx/json-patch v4.9.0+incompatible | |||
| github.com/fatih/structs v1.1.0 // indirect | |||
| github.com/gavv/httpexpect/v2 v2.2.0 | |||
| github.com/ghodss/yaml v1.0.1-0.20190212211648-25d852aebe32 | |||
There was a problem hiding this comment.
please use the sig yaml library
p.yaml
Outdated
| @@ -0,0 +1,86 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
please delete this file (you can delete wft.yaml while you're at it)
| podObjs = append(podObjs, pods.Items...) | ||
| for _, pod := range podObjs { | ||
| err = woc.controller.podInformer.GetIndexer().Add(&pod) | ||
| fmt.Println(err) |
| @@ -1395,6 +1395,8 @@ func TestWorkflowParallelismLimit(t *testing.T) { | |||
| assert.Equal(t, 2, len(pods.Items)) | |||
| // operate again and make sure we don't schedule any more pods | |||
| makePodsPhase(ctx, woc, apiv1.PodRunning) | |||
| syncPodsInformer(ctx, woc) | |||
There was a problem hiding this comment.
suggestion - could makePodsPhase call syncPodsInformer?
Signed-off-by: Saravanan Balasubramanian <[email protected]>
alexec
approved these changes
May 10, 2021
Signed-off-by: Saravanan Balasubramanian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
closes #5811