Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade github.com/gogo/protobuf. Fixes #5605 #5780

Merged
merged 1 commit into from
May 3, 2021

Conversation

NikeNano
Copy link
Contributor

@NikeNano NikeNano commented Apr 30, 2021

Signed-off-by: NikeNano [email protected]

Checklist:

Fixes #5605

@NikeNano NikeNano marked this pull request as draft April 30, 2021 11:17
@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #5780 (3dae597) into master (cb55cba) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 3dae597 differs from pull request most recent head 0cb9d81. Consider uploading reports for the commit 0cb9d81 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5780      +/-   ##
==========================================
- Coverage   46.93%   46.90%   -0.04%     
==========================================
  Files         244      244              
  Lines       15313    15313              
==========================================
- Hits         7187     7182       -5     
- Misses       7219     7222       +3     
- Partials      907      909       +2     
Impacted Files Coverage Δ
workflow/controller/operator.go 70.85% <0.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb55cba...0cb9d81. Read the comment docs.

@NikeNano NikeNano closed this May 2, 2021
@NikeNano NikeNano reopened this May 2, 2021
@NikeNano NikeNano changed the title Upgrade github.com/gogo/protobuf. Fixes: 5605 fix: upgrade github.com/gogo/protobuf. Fixes: 5605 May 2, 2021
@NikeNano NikeNano force-pushed the nikenano/upgradeGoGoProtobuf branch from e9228e9 to 8cb6ce0 Compare May 2, 2021 14:48
@NikeNano NikeNano force-pushed the nikenano/upgradeGoGoProtobuf branch from 3dae597 to 0cb9d81 Compare May 2, 2021 17:13
@NikeNano NikeNano marked this pull request as ready for review May 2, 2021 17:25
@alexec alexec changed the title fix: upgrade github.com/gogo/protobuf. Fixes: 5605 fix: upgrade github.com/gogo/protobuf. Fixes #5605 May 2, 2021
@alexec alexec merged commit 66c7709 into argoproj:master May 3, 2021
@alexec alexec added this to the v3.1 milestone May 3, 2021
@sarabala1979 sarabala1979 mentioned this pull request May 4, 2021
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade gogo/protobuf to 1.3.2
2 participants