Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add training doc #5777

Merged
merged 3 commits into from
Apr 30, 2021
Merged

docs: Add training doc #5777

merged 3 commits into from
Apr 30, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Apr 29, 2021

image

Signed-off-by: Alex Collins <[email protected]>
@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #5777 (17a13e6) into master (cb55cba) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 17a13e6 differs from pull request most recent head 4176cd3. Consider uploading reports for the commit 4176cd3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5777      +/-   ##
==========================================
- Coverage   46.93%   46.91%   -0.02%     
==========================================
  Files         244      244              
  Lines       15313    15313              
==========================================
- Hits         7187     7184       -3     
- Misses       7219     7220       +1     
- Partials      907      909       +2     
Impacted Files Coverage Δ
workflow/metrics/server.go 12.50% <0.00%> (-4.17%) ⬇️
workflow/controller/operator.go 70.85% <0.00%> (-0.27%) ⬇️
cmd/argo/commands/get.go 56.95% <0.00%> (+0.64%) ⬆️
cmd/argoexec/commands/emissary.go 50.00% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb55cba...4176cd3. Read the comment docs.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Are you planning to migrate the course assets to this repo too?

Copy link
Member

@dinever dinever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just pointing out some typos

docs/training.md Outdated Show resolved Hide resolved
docs/training.md Outdated Show resolved Hide resolved
alexec and others added 2 commits April 29, 2021 18:12
@alexec
Copy link
Contributor Author

alexec commented Apr 30, 2021

Looks great! Are you planning to migrate the course assets to this repo too?

No. Changing this repo requires PRs and each needs a detailed review. I want to avoid that for Katacoda lessons.

@alexec alexec merged commit 4aff34c into argoproj:master Apr 30, 2021
@alexec alexec deleted the training branch April 30, 2021 18:00
@sarabala1979 sarabala1979 mentioned this pull request May 4, 2021
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants