feat(controller): Inline templates. Closes #5105

[alexec]

[codecov]

Codecov Report

Merging #5749 (33f217c) into master (7f2c589) will increase coverage by 0.02%.
The diff coverage is 55.00%.

@@            Coverage Diff             @@
##           master    #5749      +/-   ##
==========================================
+ Coverage   48.50%   48.52%   +0.02%     
==========================================
  Files         260      260              
  Lines       18746    18754       +8     
==========================================
+ Hits         9092     9100       +8     
+ Misses       8661     8659       -2     
- Partials      993      995       +2     

Impacted Files	Coverage Δ
pkg/apis/workflow/v1alpha1/workflow_types.go	50.05% <0.00%> (-0.35%)	⬇️
workflow/templateresolution/context.go	59.05% <57.14%> (-2.37%)	⬇️
workflow/common/util.go	15.25% <100.00%> (+4.96%)	⬆️
workflow/controller/operator.go	72.24% <0.00%> (+0.09%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f2c589...33f217c. Read the comment docs.

[alexec]

@jessesuen could I please request your review on this? This is for v3.2, we have not released v3.1, so no hurry.

[sarabala1979]

@alexec Quick question about this feature

1. Will it support input/output artifacts and parameters?
2. Can we define the inline in workflowtemplate and refer to it?
3. Inline is referring to template struct. Will it allow to define the DAG/Step as inline?

[alexec]

• Will it support input/output artifacts and parameters?

Yes.

• Can we define the inline in workflowtemplate and refer to it?

No. It is not possible to reference inlined templates, by design.

• Inline is referring to template struct. Will it allow to define the DAG/Step as inline?

Yes/no. You can inline a DAG within a DAG, or steps within steps etc, but there is the limitation is a single inline.

[sarabala1979]

• Will it support input/output artifacts and parameters?

Yes.

• Can we define the inline in workflowtemplate and refer to it?

No. It is not possible to reference inlined templates, by design.

Can we add validation for this?

• Inline is referring to template struct. Will it allow to define the DAG/Step as inline?

Yes/no. You can inline a DAG within a DAG, or steps within steps etc, but there is the limitation is a single inline.

Can we restrict with leaf template types like 'container, script, suspend, and resource`?

[alexec]

Can we add validation for this?

I don't think we need to do this for MVP. But later on, maybe.

Can we restrict with leaf template types like 'container, script, suspend, and resource`?

Again, I don't think we need this for MVP.