Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix expr array equality operator #5744

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

crenshaw-dev
Copy link
Member

Corroborated by expr docs and one person's test in the CNCF Slack.

Checklist:

Corroborated by expr docs and one person's test in the CNCF Slack.
@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #5744 (0751265) into master (284adfe) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5744      +/-   ##
==========================================
+ Coverage   46.75%   46.78%   +0.03%     
==========================================
  Files         244      244              
  Lines       15270    15270              
==========================================
+ Hits         7139     7144       +5     
+ Misses       7227     7216      -11     
- Partials      904      910       +6     
Impacted Files Coverage Δ
workflow/controller/operator.go 70.85% <0.00%> (-0.27%) ⬇️
cmd/argo/commands/get.go 56.31% <0.00%> (+0.64%) ⬆️
server/workflow/workflow_server.go 42.73% <0.00%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 284adfe...0751265. Read the comment docs.

@crenshaw-dev crenshaw-dev changed the title Fix expr array equality operator chore: Fix expr array equality operator Apr 23, 2021
@alexec alexec merged commit 11e045d into argoproj:master Apr 23, 2021
@alexec
Copy link
Contributor

alexec commented Apr 23, 2021

Great stuff - thank you!

@sarabala1979 sarabala1979 mentioned this pull request May 4, 2021
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants