Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): Fix the issue where GetArtifact didn't look for input artifacts #5705

Merged
merged 2 commits into from
Apr 22, 2021

Conversation

dinever
Copy link
Member

@dinever dinever commented Apr 19, 2021

Fixes #5704

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #5705 (28b83df) into master (91c08cd) will increase coverage by 0.05%.
The diff coverage is 55.55%.

❗ Current head 28b83df differs from pull request most recent head 78a360e. Consider uploading reports for the commit 78a360e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5705      +/-   ##
==========================================
+ Coverage   46.91%   46.96%   +0.05%     
==========================================
  Files         244      244              
  Lines       15209    15228      +19     
==========================================
+ Hits         7135     7152      +17     
  Misses       7169     7169              
- Partials      905      907       +2     
Impacted Files Coverage Δ
workflow/executor/executor.go 16.18% <0.00%> (-0.06%) ⬇️
workflow/executor/resource.go 22.80% <0.00%> (ø)
workflow/cron/controller.go 0.75% <33.33%> (+0.75%) ⬆️
workflow/controller/operator.go 71.12% <50.00%> (+0.06%) ⬆️
server/artifacts/artifact_server.go 59.32% <84.61%> (+2.04%) ⬆️
server/cronworkflow/cron_workflow_server.go 65.07% <100.00%> (+3.01%) ⬆️
cmd/argo/commands/get.go 56.95% <0.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91c08cd...78a360e. Read the comment docs.

@dinever
Copy link
Member Author

dinever commented Apr 22, 2021

Thanks @alexec!

I've pushed the latest commit which adds two new endpoints to support input artifacts:

/input-artifacts/:namespace/:workflowName/:nodeId/:artifactName
/input-artifacts-by-uid/:uid/:nodeId/:artifactName

The original URL for output artifacts was not changed. The handler functions were renamed to GetOutputArtifacts... tho for clarification.

Please take a look when available. Thanks!

artifacts

@alexec alexec merged commit 284adfe into argoproj:master Apr 22, 2021
@alexec alexec added this to the v3.1 milestone Apr 22, 2021
@sarabala1979 sarabala1979 mentioned this pull request May 4, 2021
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetArtifact doesn't look for input artifacts
4 participants