Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tls): 3.0 defaults to tls enabled #5686

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

tczhao
Copy link
Member

@tczhao tczhao commented Apr 16, 2021

Resolves #5608

Signed-off-by: Tianchu Zhao [email protected]

Checklist:

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #5686 (d8a79c7) into master (a018523) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head d8a79c7 differs from pull request most recent head e7e86d2. Consider uploading reports for the commit e7e86d2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5686      +/-   ##
==========================================
- Coverage   47.12%   47.11%   -0.02%     
==========================================
  Files         242      242              
  Lines       15136    15136              
==========================================
- Hits         7133     7131       -2     
- Misses       7095     7097       +2     
  Partials      908      908              
Impacted Files Coverage Δ
workflow/metrics/server.go 12.50% <0.00%> (-4.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a018523...e7e86d2. Read the comment docs.

@alexec alexec merged commit cad916e into argoproj:master Apr 16, 2021
@alexec
Copy link
Contributor

alexec commented Apr 16, 2021

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation says argo server does not enable TLS by default - not true anymore since v3.0.0
2 participants