Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Correctly log version string and remove unnecessary error check #5664

Merged
merged 1 commit into from
Apr 13, 2021
Merged

chore: Correctly log version string and remove unnecessary error check #5664

merged 1 commit into from
Apr 13, 2021

Conversation

terrytangyuan
Copy link
Member

Signed-off-by: terrytangyuan [email protected]

Checklist:

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #5664 (77b060c) into master (54f4c26) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

❗ Current head 77b060c differs from pull request most recent head 0efc821. Consider uploading reports for the commit 0efc821 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5664      +/-   ##
==========================================
- Coverage   47.08%   47.03%   -0.06%     
==========================================
  Files         240      240              
  Lines       15050    15049       -1     
==========================================
- Hits         7087     7079       -8     
- Misses       7059     7063       +4     
- Partials      904      907       +3     
Impacted Files Coverage Δ
cmd/argoexec/commands/root.go 1.72% <0.00%> (+0.02%) ⬆️
cmd/argo/commands/get.go 55.66% <0.00%> (-0.65%) ⬇️
workflow/controller/operator.go 70.61% <0.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54f4c26...0efc821. Read the comment docs.

@alexec alexec merged commit ded95bc into argoproj:master Apr 13, 2021
@alexec alexec added this to the v3.1 milestone Apr 13, 2021
@terrytangyuan terrytangyuan deleted the chore-rm-check branch April 13, 2021 14:28
@simster7 simster7 mentioned this pull request Apr 19, 2021
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants