fix(controller): Correct bug for repository ref without default key. Fixes #5646 #5660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixes argoproj#5646 Signed-off-by: Alex Collins <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #5660 +/- ##
==========================================
+ Coverage 47.08% 47.11% +0.02%
==========================================
Files 240 240
Lines 15050 15050
==========================================
+ Hits 7087 7091 +4
+ Misses 7059 7057 -2
+ Partials 904 902 -2
Continue to review full report at Codecov.
|
| @@ -52,7 +53,7 @@ func (s *artifactRepositories) Resolve(ctx context.Context, ref *wfv1.ArtifactRe | |||
| } | |||
| for _, r := range refs { | |||
| resolvedRef, _, err := s.get(ctx, r) | |||
| if apierr.IsNotFound(err) { | |||
| if err != nil && (apierr.IsNotFound(err) || strings.Contains(err.Error(), "config map missing key")) { | |||
There was a problem hiding this comment.
Move this string to a constant so it can be reused by get() when emitting this error?
|
@sarabala1979 bump. |
sarabala1979
approved these changes
Apr 16, 2021
simster7
pushed a commit
that referenced
this pull request
Apr 19, 2021
…ixes #5646 (#5660) Signed-off-by: Alex Collins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5646