Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Default ARGO_SECURE=true. Fixes #5607 #5626

Merged
merged 4 commits into from
Apr 13, 2021
Merged

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Apr 8, 2021

Fixes #5607

Signed-off-by: Alex Collins <[email protected]>
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #5626 (6db775d) into master (46ec302) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head 6db775d differs from pull request most recent head 09d6de4. Consider uploading reports for the commit 09d6de4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5626      +/-   ##
==========================================
- Coverage   47.15%   47.12%   -0.04%     
==========================================
  Files         240      240              
  Lines       15060    15060              
==========================================
- Hits         7102     7097       -5     
- Misses       7054     7059       +5     
  Partials      904      904              
Impacted Files Coverage Δ
cmd/argo/commands/client/conn.go 13.33% <0.00%> (ø)
cmd/argoexec/commands/emissary.go 48.43% <0.00%> (-1.57%) ⬇️
cmd/argo/commands/get.go 56.31% <0.00%> (-0.65%) ⬇️
workflow/controller/operator.go 71.05% <0.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46ec302...09d6de4. Read the comment docs.

@alexec alexec marked this pull request as ready for review April 8, 2021 16:00
Signed-off-by: Alex Collins <[email protected]>
@alexec
Copy link
Contributor Author

alexec commented Apr 13, 2021

@simster7 bump!

@alexec alexec merged commit defbd60 into argoproj:master Apr 13, 2021
@alexec alexec deleted the secure branch April 13, 2021 18:25
@simster7 simster7 mentioned this pull request Apr 19, 2021
50 tasks
simster7 pushed a commit that referenced this pull request Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARGO_SECURE is not taken into account
2 participants