Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): various ui fixes #5606

Merged
merged 3 commits into from
Apr 8, 2021
Merged

fix(ui): various ui fixes #5606

merged 3 commits into from
Apr 8, 2021

Conversation

iven
Copy link
Contributor

@iven iven commented Apr 7, 2021

Before(overlapping):
图片
After:
图片

Before(empty scrollbar):
图片
After:
图片

Before(overlapping):
图片
After:
图片

@iven iven changed the title fix(ui): add scrollbars and prevent overlapping fix(ui): various ui fixes Apr 7, 2021
@alexec alexec requested a review from simster7 April 7, 2021 15:56
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #5606 (300442f) into master (13fa652) will not change coverage.
The diff coverage is n/a.

❗ Current head 300442f differs from pull request most recent head ed142bc. Consider uploading reports for the commit ed142bc to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5606   +/-   ##
=======================================
  Coverage   47.05%   47.05%           
=======================================
  Files         240      240           
  Lines       15030    15030           
=======================================
  Hits         7072     7072           
- Misses       7054     7057    +3     
+ Partials      904      901    -3     
Impacted Files Coverage Δ
server/workflow/workflow_server.go 41.02% <0.00%> (-1.71%) ⬇️
cmd/argo/commands/get.go 55.66% <0.00%> (-0.65%) ⬇️
workflow/controller/operator.go 71.17% <0.00%> (+0.32%) ⬆️
workflow/metrics/server.go 16.66% <0.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13fa652...ed142bc. Read the comment docs.

Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@simster7 simster7 merged commit 9d175cf into argoproj:master Apr 8, 2021
@alexec alexec added this to the v3.0 milestone Apr 8, 2021
@alexec
Copy link
Contributor

alexec commented Apr 8, 2021

Backport?

@simster7 simster7 mentioned this pull request Apr 19, 2021
50 tasks
simster7 pushed a commit that referenced this pull request Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants