Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): let workflow dag and node info scroll independently #5603

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

tczhao
Copy link
Member

@tczhao tczhao commented Apr 6, 2021

let workflow dag and node info scroll independently
so that users don't need to scroll back and forth when trying to view details from different template

before:
before

after:
after

Signed-off-by: Tianchu Zhao [email protected]

Checklist:

@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #5603 (f193322) into master (7276bc3) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head f193322 differs from pull request most recent head b7b7791. Consider uploading reports for the commit b7b7791 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5603      +/-   ##
==========================================
- Coverage   47.07%   47.05%   -0.02%     
==========================================
  Files         240      240              
  Lines       15005    15005              
==========================================
- Hits         7063     7060       -3     
- Misses       7044     7045       +1     
- Partials      898      900       +2     
Impacted Files Coverage Δ
cmd/argoexec/commands/emissary.go 48.43% <0.00%> (-1.57%) ⬇️
workflow/controller/operator.go 70.73% <0.00%> (-0.28%) ⬇️
cmd/argo/commands/get.go 56.66% <0.00%> (+0.66%) ⬆️
workflow/metrics/server.go 16.66% <0.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7276bc3...b7b7791. Read the comment docs.

@simster7 simster7 merged commit d0a0289 into argoproj:master Apr 6, 2021
@simster7 simster7 mentioned this pull request Apr 19, 2021
50 tasks
simster7 pushed a commit that referenced this pull request Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants