fix: Switch InsecureSkipVerify to true

[simster7]

Checklist:

• My organization is added to USERS.md.

[alexec]

I'm still getting

{"code":14,"message":"connection closed"}

[simster7]

Yeah, same. Looking into it

[alexec]

It works for me if I revert this:

        dialOpts := []grpc.DialOption{
                grpc.WithDefaultCallOptions(grpc.MaxCallRecvMsgSize(MaxGRPCMessageSize)),
-               grpc.WithInsecure(),
        }
+       if as.tlsConfig != nil {
+               dialOpts = append(dialOpts, grpc.WithTransportCredentials(credentials.NewTLS(as.tlsConfig)))
+       } else {
+               dialOpts = append(dialOpts, grpc.WithInsecure())
+       }
+

``

[codecov]

Codecov Report

Merging #5575 (a0d56b3) into master (ed54f15) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head a0d56b3 differs from pull request most recent head 0c909a5. Consider uploading reports for the commit 0c909a5 to get more accurate results

@@            Coverage Diff             @@
##           master    #5575      +/-   ##
==========================================
- Coverage   47.08%   47.04%   -0.05%     
==========================================
  Files         240      240              
  Lines       15002    15002              
==========================================
- Hits         7064     7057       -7     
- Misses       7041     7046       +5     
- Partials      897      899       +2     

Impacted Files	Coverage Δ
cmd/argo/commands/server.go	34.51% <0.00%> (ø)
workflow/metrics/server.go	12.50% <0.00%> (-4.17%)	⬇️
workflow/controller/operator.go	70.69% <0.00%> (-0.28%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed54f15...0c909a5. Read the comment docs.

[alexec]

And I run this

./dist/argo server --secure --port 2345

I don't seem to need GODEBUG=x509ignoreCN=0.

[simster7]

@alexec I reverted #5550 and it works. I had done so in my local from an earlier test bud hadn't noticed. I just tested and it also works for me. We should be good to go.