Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Lint master #5527

Merged
merged 1 commit into from
Mar 27, 2021
Merged

chore: Lint master #5527

merged 1 commit into from
Mar 27, 2021

Conversation

simster7
Copy link
Member

Checklist:

Signed-off-by: Simon Behar <[email protected]>
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #5527 (a8658f1) into master (a443c53) will increase coverage by 0.01%.
The diff coverage is 7.69%.

❗ Current head a8658f1 differs from pull request most recent head 2bf14f6. Consider uploading reports for the commit 2bf14f6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5527      +/-   ##
==========================================
+ Coverage   47.01%   47.03%   +0.01%     
==========================================
  Files         240      240              
  Lines       15011    15011              
==========================================
+ Hits         7058     7060       +2     
+ Misses       7055     7053       -2     
  Partials      898      898              
Impacted Files Coverage Δ
examples/validator.go 54.28% <ø> (ø)
util/util.go 27.27% <0.00%> (ø)
workflow/artifacts/git/git.go 36.78% <0.00%> (ø)
workflow/executor/common/common.go 43.90% <0.00%> (ø)
workflow/executor/emissary/binary.go 0.00% <0.00%> (ø)
workflow/executor/emissary/emissary.go 0.00% <0.00%> (ø)
workflow/executor/executor.go 16.31% <0.00%> (ø)
cmd/argoexec/commands/emissary.go 50.00% <25.00%> (+1.56%) ⬆️
workflow/metrics/server.go 12.50% <0.00%> (-4.17%) ⬇️
cmd/argo/commands/get.go 57.33% <0.00%> (+0.66%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a443c53...2bf14f6. Read the comment docs.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did the CI pass on PRs though?

@simster7
Copy link
Member Author

How did the CI pass on PRs though?

The CI only looks at PR diffs

@alexec alexec merged commit eb6f3a1 into argoproj:master Mar 27, 2021
This was referenced Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants