fix(test): Fix TestWorkflowTemplateRefWithShutdownAndSuspend flakyness

[sarabala1979]

Signed-off-by: Saravanan Balasubramanian [email protected]
fixes #5366

Checklist:

• My organization is added to USERS.md.

Based on failed. it couldn't find the pods to delete. I updated 'workflowname` so it will create pod with name.

time="2021-03-16T15:14:37Z" level=info msg="Updated message  -> Stopped with strategy 'Terminate'" namespace=default workflow=
2462
time="2021-03-16T15:14:37Z" level=info msg="Marking workflow completed" namespace=default workflow=
2463
time="2021-03-16T15:14:37Z" level=info msg="Checking daemoned children of " namespace=default workflow=
2464
time="2021-03-16T15:14:37Z" level=info msg="Workflow update successful" namespace=default phase=Failed resourceVersion= workflow=
2465
time="2021-03-16T15:14:37Z" level=info msg="Processing workflow" namespace=default workflow=
2466
time="2021-03-16T15:14:37Z" level=info msg="Updated phase  -> Running" namespace=default workflow=
2467
time="2021-03-16T15:14:37Z" level=info msg="Pod node  initialized Pending" namespace=default workflow=
2468
time="2021-03-16T15:14:37Z" level=info msg="Workflow update successful" namespace=default phase=Running resourceVersion= workflow=
2469
time="2021-03-16T15:14:37Z" level=info msg="Processing workflow" namespace=default workflow=
2470
time="2021-03-16T15:14:37Z" level=info msg="Deleting Pending pod default/ as part of workflow shutdown with strategy: Stop" namespace=default workflow=
2471
time="2021-03-16T15:14:38Z" level=warning msg="Failed to delete default/: pods \"\" not found" namespace=default workflow=
2472
time="2021-03-16T15:14:38Z" level=info msg="Applying shutdown deadline for pod " namespace=default workflow=
2473
time="2021-03-16T15:14:38Z" level=info msg="Updating execution control of : {\"deadline\":\"0001-01-01T00:00:00Z\",\"includeScriptOutput\":true}" namespace=default workflow=

[codecov]

Codecov Report

Merging #5418 (d04b04d) into master (d3079b3) will increase coverage by 0.04%.
The diff coverage is 19.75%.

@@            Coverage Diff             @@
##           master    #5418      +/-   ##
==========================================
+ Coverage   16.19%   16.24%   +0.04%     
==========================================
  Files         243      243              
  Lines       43697    43689       -8     
==========================================
+ Hits         7078     7097      +19     
+ Misses      35644    35617      -27     
  Partials      975      975              

Impacted Files	Coverage Δ
cmd/argoexec/commands/resource.go	0.00% <0.00%> (ø)
cmd/argoexec/commands/root.go	1.69% <0.00%> (-0.06%)	⬇️
workflow/controller/controller.go	20.25% <0.00%> (-0.92%)	⬇️
workflow/controller/pod_cleanup_key.go	20.00% <ø> (ø)
workflow/executor/executor.go	16.05% <0.00%> (-0.03%)	⬇️
workflow/controller/operator.go	70.27% <12.50%> (-0.21%)	⬇️
workflow/executor/resource.go	23.63% <34.88%> (+13.05%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3079b3...37af822. Read the comment docs.

[terrytangyuan]

LGTM