Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make start tails logs #5416

Merged
merged 42 commits into from
Mar 18, 2021
Merged

build: make start tails logs #5416

merged 42 commits into from
Mar 18, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Mar 16, 2021

No description provided.

@alexec alexec changed the title build: Show logs on make start build: make start tails logs Mar 16, 2021
@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #5416 (2d48cfe) into master (2371a6d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 2d48cfe differs from pull request most recent head 2be3a91. Consider uploading reports for the commit 2be3a91 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5416   +/-   ##
=======================================
  Coverage   16.28%   16.29%           
=======================================
  Files         243      243           
  Lines       43666    43666           
=======================================
+ Hits         7113     7114    +1     
+ Misses      35584    35583    -1     
  Partials      969      969           
Impacted Files Coverage Δ
workflow/controller/operator.go 70.87% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2371a6d...2be3a91. Read the comment docs.

@@ -172,9 +172,6 @@ func (g *Given) Exec(name string, args []string, block func(t *testing.T, output
g.t.Helper()
output, err := Exec(name, args...)
block(g.t, output, err)
if g.t.Failed() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FailNow (and therefore Fatal) cause both the current test, and the whole suite, to stop running. This means only one test can fail per suite, but there maybe more you want to know about.

Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
@alexec alexec marked this pull request as ready for review March 17, 2021 04:23
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
@alexec alexec merged commit fc8ecc4 into argoproj:master Mar 18, 2021
@alexec alexec deleted the logs branch March 18, 2021 17:03
@simster7 simster7 mentioned this pull request Mar 22, 2021
34 tasks
@simster7 simster7 mentioned this pull request Mar 29, 2021
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants