Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add helper functions to expr when parsing metadata. Fixes #5351 #5374

Merged
merged 2 commits into from
Mar 12, 2021
Merged

feat: Add helper functions to expr when parsing metadata. Fixes #5351 #5374

merged 2 commits into from
Mar 12, 2021

Conversation

svmaris
Copy link

@svmaris svmaris commented Mar 11, 2021

This allows you to do this in your WorkflowEventBinding:

spec:
  event:
    selector: ...
  submit:
    metadata:
      name: 'payload.repository.slug + "-" + sprig.trunc(8, payload.changes[0].toHash)'

Signed-off-by: Stephan van Maris [email protected]

Checklist:

@svmaris svmaris changed the title feat: Add helper functions to expr when parsing metadata. Fixes #5351. feat: Add helper functions to expr when parsing metadata. Fixes #5351 Mar 11, 2021
@svmaris svmaris mentioned this pull request Mar 11, 2021
Closed
alexec
alexec approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was easier than I expected! good work

alexec
alexec requested changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look like you need to run make lint to fix the imports for your change, see the codegen failed job

ran make lint
aee0c0f 
Signed-off-by: Stephan van Maris <[email protected]>
@svmaris
Copy link
Author

svmaris commented Mar 12, 2021

Not sure why the test is failing?

alexec
alexec approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test is a flake - ignore

@alexec alexec merged commit 1f7cf1e into argoproj:master Mar 12, 2021
@alexec alexec added this to the v3.1 milestone Mar 12, 2021
@simster7 simster7 mentioned this pull request Mar 15, 2021
Closed
27 tasks
@simster7 simster7 mentioned this pull request Mar 29, 2021
Closed
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@svmaris @alexec