fix: Makefile target #5313
Merged
fix: Makefile target #5313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Behar <[email protected]>
simster7
commented
Mar 5, 2021
| @@ -28,7 +28,7 @@ VERSION := $(GIT_TAG) | |||
| endif | |||
|
|
|||
| # should we build the static files? | |||
| ifneq (,$(filter $@,codegen|lint|test|docs)) | |||
| ifneq (,$(filter $(MAKECMDGOALS),codegen lint test docs start)) | |||
There was a problem hiding this comment.
Only GNU Make supports $@. $(MAKECMDGOALS) is supported by all makes.
Also, make start does not need static files as the UI is built and served by webpack
alexec
approved these changes
Mar 5, 2021
This was referenced Mar 8, 2021
Closed
Closed
simster7
added a commit
that referenced
this pull request
Mar 8, 2021
Signed-off-by: Simon Behar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: