Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support ListObjects() for Alibaba OSS artifact driver #5261

Merged
merged 1 commit into from
Mar 3, 2021
Merged

feat: Support ListObjects() for Alibaba OSS artifact driver #5261

merged 1 commit into from
Mar 3, 2021

Conversation

terrytangyuan
Copy link
Member

This is to support data sourcing and transformation with the data template implemented in #4958.

cc @simster7 @alexec

Signed-off-by: terrytangyuan [email protected]

Checklist:

@alexec
Copy link
Contributor

alexec commented Mar 2, 2021

yes please, @simster7 can we create a v1.1 ticket for GCP too please?

@simster7
Copy link
Member

simster7 commented Mar 2, 2021

We have intentionally left this off as we want to keep the scope of data v1.0 small. I will add this once I add the rest of the drivers on v1.1

@simster7 simster7 closed this Mar 2, 2021
@simster7
Copy link
Member

simster7 commented Mar 2, 2021

Thanks for submitting thought

@terrytangyuan
Copy link
Member Author

We cannot test out this feature for OSS though without this implementation.

@alexec
Copy link
Contributor

alexec commented Mar 2, 2021

@simster7 I think we should accept this PR. The onus would be on @terrytangyuan to implement and test because we do not run OSS ourselves.

@simster7
Copy link
Member

simster7 commented Mar 2, 2021

The onus would be on @terrytangyuan to implement and test because we do not run OSS ourselves.

Sure, fair point. I had wanted to add all the drivers in one atomic request, but this makes sense

@simster7 simster7 reopened this Mar 2, 2021
@simster7
Copy link
Member

simster7 commented Mar 2, 2021

@terrytangyuan Do you plan on testing data off of master/latest soon? Otherwise I will delay merging this until I have written the rest of the drivers

@terrytangyuan
Copy link
Member Author

Yes I was planning to test it out once merged anyways.

@simster7 simster7 merged commit 66fa8da into argoproj:master Mar 3, 2021
@terrytangyuan terrytangyuan deleted the oss-list branch March 3, 2021 17:07
This was referenced Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants