fix(controller): Work-around Golang flaw. Fixes #5192 #5230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simster7 any chance of a code review on this? I'd like to backport it to v2.12 and to v3.0. |
simster7
approved these changes
Mar 1, 2021
Signed-off-by: Alex Collins <[email protected]>
sarabala1979
reviewed
Mar 2, 2021
| } | ||
| return string(jsonBytes) | ||
| return jsonutil.Fix(string(x)) |
There was a problem hiding this comment.
Suggestion:
Can it be the common wrapper function json.Marshal which contains the above definition? So, the developer will call the wrapper function instead of call json.Marshal and jsonutil.fix.
sarabala1979
approved these changes
Mar 2, 2021
This was referenced Mar 8, 2021
Closed
Closed
simster7
pushed a commit
that referenced
this pull request
Mar 8, 2021
Signed-off-by: Alex Collins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5192