chore: Remove uses of deprecated fields in docs and manifests #5200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: terrytangyuan <[email protected]>
Signed-off-by: terrytangyuan <[email protected]>
alexec
reviewed
Feb 25, 2021
This reverts commit 5551b3c. Signed-off-by: terrytangyuan <[email protected]>
This reverts commit 0c67d4c. Signed-off-by: terrytangyuan <[email protected]>
Signed-off-by: terrytangyuan <[email protected]>
Agreed that it may not be good timing. I've updated the PR to just remove uses of deprecated fields in docs and manifests instead. |
terrytangyuan
commented
Feb 25, 2021
| @@ -1,7 +1,6 @@ | |||
| # This example shows the ability to automatically delete workflows after a specified time period | |||
| # after the workflow completes. The TTLStrategy sets the strategy for how long workflows that are | |||
| # successful, not successful, or completed should live. The former ttlSecondsAfterFinished will be | |||
| # deprecated and will be replaced with TTLStrategy.SecondsAfterCompleted. | |||
There was a problem hiding this comment.
This field is already removed.
| @@ -647,7 +647,6 @@ data: | |||
| scope: sensor-logs | |||
| url: https://logging-facility?namespace=${metadata.namespace}&podName=${metadata.name}&startedAt=${status.startedAt}&finishedAt=${status.finishedAt} | |||
| metricsConfig: | | |||
| disableLegacy: true | |||
There was a problem hiding this comment.
This field is not used and will be have no effect.
alexec
approved these changes
Mar 4, 2021
This was referenced Mar 8, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: terrytangyuan [email protected]
Checklist: