fix: Propagate URL changes to react state #5188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5186
The react
useState
takes as parameter only an initial value. Once the hooks are created, if the value passed in touseState
changes it has no effect on the state of the hooks.https://reactjs.org/docs/hooks-reference.html#usestate
Since the only way the react state reads the query parameters is as an argument to
useState
, if we change the URL without changing the react state, the change will not propagate to down to the react state. With this change, we use an effect on the history, so if the history were to change, we would make sure to update our react state with new query param values.