feat: Support automatically create OSS bucket if not exists #5133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
reviewed
Feb 19, 2021
workflow/artifacts/oss/oss.go
Outdated
Comment on lines
65
to
76
| exists, err := osscli.IsBucketExist(bucketName) | ||
| if err != nil { | ||
| return false, fmt.Errorf("failed to check if bucket %s exists: %w", bucketName, err) | ||
| } | ||
| if !exists && outputArtifact.OSS.CreateBucketIfNotPresent { | ||
| err = osscli.CreateBucket(bucketName) | ||
| if err != nil { | ||
| log.Warnf("failed to automatically create bucket %s when it's not present: %v", bucketName, err) | ||
| } | ||
| } |
There was a problem hiding this comment.
Can this refactored to only execute IsBucketExists if CreateBucketIfNotPresent is true?
Signed-off-by: terrytangyuan <[email protected]>
Signed-off-by: terrytangyuan <[email protected]>
alexec
approved these changes
Feb 19, 2021
|
LGTM |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: terrytangyuan [email protected]
Checklist: