fix: Correct usage of wait.ExponentialBackoff #4962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Collins <[email protected]>
alexec
commented
Jan 28, 2021
| if err != nil { | ||
| log.Warnf("Failed to wait for container id '%s': %v", mainContainerID, err) | ||
| return false, err | ||
| return false, nil |
There was a problem hiding this comment.
previously this code would have NEVER retried
There was a problem hiding this comment.
After this exponentialBackoff this function needs to return the original error instead of ErrWaitTimeout
alexec
commented
Jan 28, 2021
| @@ -395,7 +395,7 @@ func (p *PNSExecutor) GetTerminatedContainerStatus(ctx context.Context, containe | |||
| containerStatus = &containerStatusRes | |||
| return containerStatus.State.Terminated != nil, nil | |||
| } | |||
| return false, errors.New(errors.CodeNotFound, fmt.Sprintf("containerID %q is not found in the pod %s", containerID, p.podName)) | |||
| return false, nil | |||
There was a problem hiding this comment.
I've noted that it can take a bit longer to get the container IDs in the pod status - so we should not error - we should retry
There was a problem hiding this comment.
Same as the previous comment, the original error needs to return from this function instead of ErrWaitTimeout
| @@ -59,7 +60,7 @@ func (o *Operation) Dispatch(ctx context.Context) { | |||
| nameSuffix := fmt.Sprintf("%v", time.Now().Unix()) | |||
| err := wait.ExponentialBackoff(retry.DefaultRetry, func() (bool, error) { | |||
| _, err := o.dispatch(ctx, event, nameSuffix) | |||
| return err == nil, err | |||
| return errorsutil.Done(err) | |||
jessesuen
approved these changes
Jan 28, 2021
copierrj
pushed a commit
to PDOK/argo-workflows
that referenced
this pull request
Mar 22, 2021
Signed-off-by: Alex Collins <[email protected]>
copierrj
pushed a commit
to PDOK/argo-workflows
that referenced
this pull request
Mar 23, 2021
Signed-off-by: Alex Collins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The take-away here is that - if you want a retry, you must not return an error. However, we were doing that a LOT.
Frustratingly, this will obfuscate the underlying error when we have many transient errors- you'll get ErrWaitTimeout.