feat(cli): add phase option to node set command
#4825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
changed the title
alexec
changed the title
node set command
alexec
changed the title
node set commandnode set command
simster7
approved these changes
Jan 4, 2021
|
Needs codegen and commit signing |
markterm
force-pushed
the
add-phase-option-to-node-command
branch
from
ce442b8
to
d8d94ee
Compare
Signed-off-by: Mark White <[email protected]>
markterm
force-pushed
the
add-phase-option-to-node-command
branch
from
d8d94ee
to
aaea245
Compare
saranyaeu2987
pushed a commit
to saranyaeu2987/argo-1
that referenced
this pull request
Jan 5, 2021
Signed-off-by: Mark White <[email protected]> Signed-off-by: saranyaeu2987 <[email protected]>
simster7
pushed a commit
that referenced
this pull request
Jan 12, 2021
Signed-off-by: Mark White <[email protected]>
|
Fix for this is out now in https://github.com/argoproj/argo/releases/tag/v2.12.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
This adds the missing 'phase' command to the node cli command, eg:
argo node set my-wf --node-field-selector displayName=approve --phase Succeededwould set the phase for the suspend node with displayName=approve to Succeeded