Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): k8s_request_total and workflow_condition metrics #4811

Merged
merged 20 commits into from
Jan 12, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Dec 29, 2020

No description provided.

@alexec alexec changed the base branch from test to master January 4, 2021 18:47
@alexec alexec changed the title poc: Various metrics and performance fixes feat: Various metrics and performance fixes PoC Jan 4, 2021
@alexec alexec linked an issue Jan 6, 2021 that may be closed by this pull request
@alexec alexec changed the title feat: Various metrics and performance fixes PoC feat: Various metrics fixes PoC Jan 6, 2021
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
@alexec alexec changed the title feat: Various metrics fixes PoC feat(controller): K8S and pod_running metrics Jan 7, 2021
@alexec alexec changed the title feat(controller): K8S and pod_running metrics feat(controller): k8s_request_total and workflow_condition metric Jan 8, 2021
@alexec alexec changed the title feat(controller): k8s_request_total and workflow_condition metric feat(controller): k8s_request_total and workflow_condition metrics Jan 8, 2021
@alexec alexec marked this pull request as ready for review January 8, 2021 16:55
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -34,3 +34,4 @@ git-ask-pass.sh
/.brew_home
/go-diagrams/
/.run/
pprof
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +96 to +98
go func() {
log.Println(http.ListenAndServe("localhost:6060", nil))
}()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the log.Println?

Comment on lines +877 to +879
if node.Phase == wfv1.NodeRunning {
podRunningCondition.Status = metav1.ConditionTrue
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean

@alexec alexec merged commit 45c792a into argoproj:master Jan 12, 2021
@alexec alexec deleted the test branch January 12, 2021 02:47
@alexec alexec added this to the v3.0 milestone Jan 12, 2021
@simster7 simster7 mentioned this pull request Jan 12, 2021
15 tasks
@alexec alexec mentioned this pull request Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More Prometheus metrics
2 participants