fix(server): Do not silently ignore sso secret creation error #4775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Collins <[email protected]>
| @@ -139,10 +140,13 @@ func newSso( | |||
| // if it fails, then the get will fail, and the pod restart | |||
| // it may fail due to race condition with another pod - which is fine, | |||
| // when it restart it'll get the new key | |||
| _, _ = secretsIf.Create(&apiv1.Secret{ | |||
| _, err = secretsIf.Create(&apiv1.Secret{ | |||
There was a problem hiding this comment.
RBAC should have 'create` permission. right?
There was a problem hiding this comment.
correct - that is already the case - this surfaces issue when users have their own custom RBAC
sarabala1979
approved these changes
Dec 18, 2020
simster7
pushed a commit
that referenced
this pull request
Jan 4, 2021
Signed-off-by: Alex Collins <[email protected]>
|
Fix for this is out on https://github.com/argoproj/argo/releases/tag/v2.12.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Collins [email protected]
Checklist: