Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds millisecond-level timestamps to argo and workflow-controller #4518

Merged
merged 2 commits into from
Nov 13, 2020

Conversation

mikhailian
Copy link
Contributor

Adding millisecond-level timestamps in follow-up to #2795 so that we have them everywhere and not just in argoexec. Thanks to @astein-te for implementing the original feature request.

@CLAassistant
Copy link

CLAassistant commented Nov 11, 2020

CLA assistant check
All committers have signed the CLA.

@mikhailian mikhailian force-pushed the add-millisecond-level-timestamps branch 4 times, most recently from 04eed76 to 31db724 Compare November 12, 2020 09:52
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we want to make this setting configurable, but I don't really see a point to doing so. Any thoughts?

cmd/workflow-controller/main.go Outdated Show resolved Hide resolved
@simster7 simster7 self-assigned this Nov 13, 2020
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@simster7 simster7 merged commit 411bde3 into argoproj:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants