feat: Redirect to requested URL after SSO login #4495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Behar <[email protected]>
simster7
commented
Nov 9, 2020
| state := pkgrand.RandString(10) | ||
| http.SetCookie(w, &http.Cookie{ | ||
| Name: stateCookieName, | ||
| Value: state, | ||
| Name: state, |
There was a problem hiding this comment.
https://auth0.com/docs/protocols/state-parameters#use-the-stored-url-to-redirect-users recommends using the nonce/state as the name of the cookie for added security
| if err != nil { | ||
| w.WriteHeader(400) | ||
| _, _ = w.Write([]byte(fmt.Sprintf("invalid state: %v", err))) | ||
| return | ||
| } | ||
| if state != cookie.Value { |
There was a problem hiding this comment.
No need to check this anymore, since the name of the cookie is the state
Signed-off-by: Simon Behar <[email protected]>
Signed-off-by: Simon Behar <[email protected]>
Signed-off-by: Simon Behar <[email protected]>
|
Test failure is unrelated: #4501 |
alexec
approved these changes
Nov 10, 2020
|
@alexec I like that suggestion, will do. |
alexcapras
pushed a commit
to alexcapras/argo
that referenced
this pull request
Nov 12, 2020
Signed-off-by: Simon Behar <[email protected]> Signed-off-by: Alex Capras <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #4496
Closes: #4370
Signed-off-by: Simon Behar [email protected]
Checklist: