Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): make SSO session expiry configurable #4494

Merged
merged 1 commit into from
Nov 15, 2020

Conversation

arghya88
Copy link
Contributor

@arghya88 arghya88 commented Nov 9, 2020

Signed-off-by: Arghya Sadhu [email protected]

Checklist:

Fixes #3873

@arghya88 arghya88 force-pushed the sso-config branch 3 times, most recently from 7324ff3 to fc155c0 Compare November 9, 2020 13:27
server/auth/sso/sso.go Outdated Show resolved Hide resolved
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change requested

@arghya88 arghya88 force-pushed the sso-config branch 3 times, most recently from f8f722c to e01823b Compare November 9, 2020 16:10
server/auth/sso/sso.go Outdated Show resolved Hide resolved
server/auth/sso/sso.go Outdated Show resolved Hide resolved
server/auth/sso/sso.go Outdated Show resolved Hide resolved
server/auth/sso/sso.go Outdated Show resolved Hide resolved
@arghya88 arghya88 force-pushed the sso-config branch 4 times, most recently from 213daf8 to 179f5a7 Compare November 10, 2020 17:56
server/auth/sso/sso.go Outdated Show resolved Hide resolved
server/auth/sso/sso_test.go Outdated Show resolved Hide resolved
server/auth/sso/sso_test.go Outdated Show resolved Hide resolved
@arghya88 arghya88 force-pushed the sso-config branch 7 times, most recently from 0e6c4d3 to 211b7cb Compare November 15, 2020 03:53
@alexec alexec changed the title feat(controller): make sso timeout configurable via configmap feat(controller): make SSO session expiry configurable Nov 15, 2020
@alexec alexec merged commit 4bacbc1 into argoproj:master Nov 15, 2020
@alexec
Copy link
Contributor

alexec commented Nov 15, 2020

Needs backporting to v2.12

@alexec alexec added this to the v2.12 milestone Nov 15, 2020
alexcapras pushed a commit to alexcapras/argo that referenced this pull request Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSO Timeout Configuration
2 participants