fix(controller): support float for param value #4490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
arghya88
changed the title
arghya88
force-pushed
the
float-support
branch
3 times, most recently
from
413d81b
to
4544657
Compare
arghya88
changed the title
alexec
reviewed
Nov 9, 2020
arghya88
force-pushed
the
float-support
branch
9 times, most recently
from
5861cc1
to
4c4c336
Compare
|
You have a failing unit test? |
arghya88
force-pushed
the
float-support
branch
from
4c4c336
to
3cb9f5a
Compare
@alexec probably flake. Fixed now |
alexec
reviewed
Nov 10, 2020
|
I was just about the send a similar PR to fix this as well from a working branch and then found this one. Thanks @arghya88! |
|
@terrytangyuan good comment - thank you! |
arghya88
force-pushed
the
float-support
branch
5 times, most recently
from
9de7f91
to
0071fc5
Compare
alexec
approved these changes
Nov 14, 2020
arghya88
force-pushed
the
float-support
branch
2 times, most recently
from
b65f396
to
1b93935
Compare
alexec
reviewed
Nov 15, 2020
arghya88
force-pushed
the
float-support
branch
from
c3d9fc9
to
458b646
Compare
Signed-off-by: Arghya Sadhu <[email protected]>
arghya88
force-pushed
the
float-support
branch
from
458b646
to
dd30b4f
Compare
|
Needs backporting to v2.12 |
@alexec I will submit a PR for that |
No need. Will do this for you. |
alexcapras
pushed a commit
to alexcapras/argo
that referenced
this pull request
Dec 2, 2020
Signed-off-by: Arghya Sadhu <[email protected]> Signed-off-by: Alex Capras <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Fixes #4478