Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Argo Events API and UI. Fixes #888 #4470

Merged
merged 90 commits into from
Jan 15, 2021
Merged

feat(ui): Argo Events API and UI. Fixes #888 #4470

merged 90 commits into from
Jan 15, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Nov 5, 2020

Checklist:

Features

  • New API endpoints for Argo Events
  • New event-flow page
  • Create, edit, view, log event sources and sensors in the UI
  • Embeddable widgets
  • New workflow log viewer
  • Configurable "Get help" button
  • Refactored code to use more robust React functional components
  • Seemless reconnection on network errors
  • Many small tweaks
  • Lots of bugs fixed

Fixes #888

@alexec alexec changed the title feat(ui): Support Argo Events in the UI. feat(ui): Support Argo Events in the UI. Fixes #888 Nov 5, 2020
Makefile Outdated Show resolved Hide resolved
alexec and others added 15 commits December 15, 2020 17:25
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Simon Behar <[email protected]>
@alexec
Copy link
Contributor Author

alexec commented Jan 4, 2021

@jessesuen @sarabala1979 @simster7 I'm pondering what to do with this PR now. It does contain two major items: the Argo Events UI and the GUI workflow editor. However, we now have feedback that a workflow editor is not very useful to users, one person found it confusing.

One option - only have Argo Events :

  • Remove the workflow editor from this PR and only have the Argo Events code. Maybe be do a later PR for that code.

Pros will reduce complexity and bugs
Con: loses lots of code refactored to use useEffect which is 10x easy to debug.

Thoughts?

@simster7
Copy link
Member

simster7 commented Jan 4, 2021

@alexec I am a fan of a lot of the code refactors in this PR, including useEffect. Is it feasible to revert just the Workflow editor and keep the rest in? I'd be happy to discuss my ideas more in depth during stand up, I gathered some feedback on the UI and was planning on sharing anyway.

@alexec
Copy link
Contributor Author

alexec commented Jan 4, 2021

@simster7 lets discus at stand-up. I think v3.0 is really pack with stuff and we're going to need to really focus and push to get it out in the time frame MK's requested.

Signed-off-by: Alex Collins <[email protected]>
}
rpc UpdateSensor (UpdateSensorRequest) returns (github.com.argoproj.argo_events.pkg.apis.sensor.v1alpha1.Sensor) {
option (google.api.http) = {
put: "/api/v1/sensors/{namespace}/{name}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, that if you use {sensor.metadata.name} instead of {name}, then you don't need to introduce a name field in UpdateSensorRequest.

i.e.

put: "api/v1/sensors/{namespace}/{sensor.metadata.name}"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice - we should leverage this all over

Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Sensor dashboard to UI
5 participants