Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Github issue templates #4161

Merged
merged 4 commits into from
Sep 30, 2020
Merged

chore: Update Github issue templates #4161

merged 4 commits into from
Sep 30, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Sep 29, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@alexec
Copy link
Contributor Author

alexec commented Sep 29, 2020

Unrelated failure, maybe bug or flakey test?

2020-09-29T18:46:09.0493329Z --- FAIL: TestArgoServerSuite (37.70s)
2020-09-29T18:46:09.0494342Z     --- FAIL: TestArgoServerSuite/TestArchivedWorkflowService (4.12s)
2020-09-29T18:46:09.0498920Z ##[error]        argo_server_test.go:1142: workflows.argoproj.io "archie" not found

@alexec alexec marked this pull request as ready for review September 29, 2020 19:04
@alexec alexec added this to the v2.12 milestone Sep 30, 2020
@alexec alexec merged commit b3db0f5 into argoproj:master Sep 30, 2020
@alexec alexec deleted the tmpl branch September 30, 2020 19:35
alexcapras pushed a commit to alexcapras/argo that referenced this pull request Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants