Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Delete realtime metrics of running Workflows that are deleted #3993

Merged
merged 2 commits into from
Sep 14, 2020
Merged

fix: Delete realtime metrics of running Workflows that are deleted #3993

merged 2 commits into from
Sep 14, 2020

Conversation

simster7
Copy link
Member

Fixes: #3992

Still needs testing

@simster7 simster7 marked this pull request as ready for review September 11, 2020 20:20
alexec
alexec approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mainly a rubber-stamp approval - I trust you to have created the right tests.

@simster7 simster7 merged commit ae77959 into argoproj:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Realtime metrics are not stopped or deleted if owner Workflow is deleted or terminated while it's running
2 participants
@simster7 @alexec